fix crane's root.go after DefaultTransport change#1450
Merged
mattmoor merged 1 commit intogoogle:mainfrom Sep 20, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1450 +/- ##
=======================================
Coverage 73.31% 73.31%
=======================================
Files 115 115
Lines 8772 8772
=======================================
Hits 6431 6431
Misses 1696 1696
Partials 645 645
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattmoor
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1449 changed
remote.DefaultTransportto be ahttp.RoundTripperinstead of a*http.Transport, and made a corresponding change incraneto callCloneonly if the providedRoundTripperwas also cloneable. It was overly clever, and unnecessary, and seems to have brokencrane's insecure repo support.