mysql/awsmysql: support IAM authenticate with AssumeRole#3623
Merged
Conversation
f566e5d to
79be7c0
Compare
Contributor
Author
|
cc @vangent for review. |
giautm
commented
Oct 22, 2025
giautm
commented
Oct 22, 2025
vangent
reviewed
Oct 22, 2025
Contributor
Author
|
@vangent addressed all your comments, please review again. This current blocking me to switch between IAM user and local docker user/password authentication. |
vangent
reviewed
Oct 22, 2025
vangent
left a comment
Contributor
There was a problem hiding this comment.
The tests are failing, can you try running locally?
FAIL gocloud.dev/samples/guestbook [setup failed]
vangent
reviewed
Oct 23, 2025
vangent
left a comment
Contributor
There was a problem hiding this comment.
Now
FAIL: dependencies changed; run: internal/testing/listdeps.sh > internal/testing/alldeps
Contributor
Author
|
I already run it but no change on Mac |
Contributor
Author
|
Revert the changes make it green, however the output is difference on Mac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.