Skip to content

blob/fileblob: Support relative paths in URL openers via a host of "."#2796

Merged
vangent merged 2 commits into
google:masterfrom
vangent:rel
May 31, 2020
Merged

blob/fileblob: Support relative paths in URL openers via a host of "."#2796
vangent merged 2 commits into
google:masterfrom
vangent:rel

Conversation

@vangent

@vangent vangent commented May 21, 2020

Copy link
Copy Markdown
Contributor

Fixes #2795.

@googlebot googlebot added the cla: yes Google CLA has been signed! label May 21, 2020
@codecov

codecov Bot commented May 21, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2796 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2796      +/-   ##
==========================================
- Coverage   68.30%   68.24%   -0.06%     
==========================================
  Files         115      115              
  Lines       13347    13347              
==========================================
- Hits         9117     9109       -8     
- Misses       3572     3582      +10     
+ Partials      658      656       -2     
Impacted Files Coverage Δ
blob/fileblob/fileblob.go 80.57% <100.00%> (+0.57%) ⬆️
server/health/sqlhealth/sqlhealth.go 61.90% <0.00%> (-19.05%) ⬇️
runtimevar/filevar/filevar.go 85.32% <0.00%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee021b...5d3d9c4. Read the comment docs.

@vangent vangent requested a review from eliben May 21, 2020 23:30
@vangent

vangent commented May 30, 2020

Copy link
Copy Markdown
Contributor Author

gentle ping eliben@ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Google CLA has been signed!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

blob/fileblob: Support relative paths in bucket URL

3 participants