secrets/azurekeyvault: add a way to use az CLI auth; provide a better resource default#2463
Merged
Conversation
… resource default
shantuo
approved these changes
Jul 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #2463 +/- ##
=========================================
Coverage ? 70.38%
=========================================
Files ? 118
Lines ? 13611
Branches ? 0
=========================================
Hits ? 9580
Misses ? 3366
Partials ? 665
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2462.
If you set
AZURE_KEYVAULT_AUTH_VIA_CLIto a truthy value, the defaultURLOpenerwill now get authorization from theazCLI instead of from the environment (there are 2 different functions in the Azureauthlibrary for this). We also expose both forms via the existingDialand a newDialUsingCLIAuth.If you provide a
AZURE_AD_RESOURCE, we use it, but if you don't, we usehttps://vault.azure.net. The Azureauthlibrary defaults it to the "management" resource, which is wrong for KeyVault.Fixed a bug in URL parsing where the URL was parsed incorrectly if the version was included.