Skip to content

Depth/Stencil GPU written Texture fixes #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pmuetschard merged 2 commits into from
Jun 6, 2019
Merged

Depth/Stencil GPU written Texture fixes #2800

pmuetschard merged 2 commits into from
Jun 6, 2019

Conversation

@pmuetschard
Copy link
Member

@pmuetschard pmuetschard commented Jun 4, 2019

  • Correctly deal with GPU written depth_stencil textures.
  • Fix a depth texture read back issue.

Fixes #2740

@pmuetschard
Correctly deal with GPU written depth_stencil textures.
4d4718b 
Since we cannot actually readback stencil data, simply clear it to
zeros in the conversion.
@pmuetschard
Fix a depth texture read back issue.
cc41338 
Fixes google#2740
@pmuetschard pmuetschard requested review from AWoloszyn and hevrard June 4, 2019 01:13
@pmuetschard pmuetschard merged commit d7c37c9 into google:master Jun 6, 2019
@pmuetschard pmuetschard deleted the depth_stencil branch June 6, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hevrard hevrard Awaiting requested review from hevrard

1 more reviewer

@AWoloszyn AWoloszyn AWoloszyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid format for GL_DEPTH_COMPONENT, GL_UNSIGNED_SHORT

3 participants

@pmuetschard @AWoloszyn @googlebot