Allowed changes to the SSH config while gapis is running. #2602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9470cef to
46e0442
Compare
qining
approved these changes
Feb 12, 2019
core/os/device/remotessh/device.go
Outdated
| } | ||
| } | ||
|
|
||
| // Devices returns the list of attached Android devices. |
core/os/device/remotessh/device.go
Outdated
| }() | ||
| configs := []Configuration{} | ||
| for _, rc := range rcs { | ||
| configurations, err := ReadConfigurations(rc) |
Contributor
There was a problem hiding this comment.
Nit: Looks like there are some shared code here and in remotessh.Devices(), they all read a list of configurations and then call scanDevices
This will periodically poll for SSH devices, and update the file that contains that data as necessary. This also preps some work to allow us to specify multiple ssh_config files.
46e0442 to
b323e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will periodically poll for SSH devices, and update the
file that contains that data as necessary.