Use a more robust way to retrieve screen states #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your PR @zhangyiwei. The change looks good - we just need to update the tests. (You can run them all with The failing test is here and can be run with |
Contributor
Author
|
Thanks for your review, and sorry for the missing bit. Will send an update soon. |
Contributor
Author
|
The update is combined in the 1 commit because of getting rid of false merge commits. The related tests have passed. Let me know if there's any other concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation won't work on late Android Pie releases because dumpsys window policy removed the state flag for display and lockguard. This change proposed a more robust and consistent way for retrieving screen states using power manager and activity manager.