Vulkan: Allocation optimization for byte slice during state rebuilding #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
reviewed
Jun 27, 2018
gapis/api/vulkan/state_rebuilder.go
Outdated
| func (sb *stateBuilder) allocAndFillScratchBuffer(device DeviceObjectʳ, data []uint8, usages ...VkBufferUsageFlagBits) (VkBuffer, VkDeviceMemory) { | ||
| buffer := VkBuffer(newUnusedID(true, func(x uint64) bool { return sb.s.Buffers().Contains(VkBuffer(x)) })) | ||
| deviceMemory := VkDeviceMemory(newUnusedID(true, func(x uint64) bool { return sb.s.DeviceMemories().Contains(VkDeviceMemory(x)) })) | ||
| type bufSubRngFillInfo struct { |
Contributor
There was a problem hiding this comment.
For class names, can we use the full words, bufferSubRangeFillInfo.
AWoloszyn
suggested changes
Jun 27, 2018
Contributor
AWoloszyn
left a comment
There was a problem hiding this comment.
A couple of minor requests.
For a typical Vulkan application, this saves ~300MB memory used for storing the slice data.
8ec5077 to
b113ceb
Compare
Contributor
Author
Do not handle the data used in "image priming through imageStore", as
|
AWoloszyn
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a typical Vulkan application, this saves ~200MB memory used for
storing the slice data.