Skip to content

Optimize byte slice copies #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AWoloszyn merged 1 commit into from
May 25, 2018
Merged

Optimize byte slice copies #1920

AWoloszyn merged 1 commit into from
May 25, 2018

Conversation

@AWoloszyn
Copy link
Contributor

@AWoloszyn AWoloszyn commented May 25, 2018

This optimizes byte slice operations, we know the alignment/padding of all byte slice copies, and can short-circuit that.

sha                         | 439258          | 9763af
report-time                 | 35.587207037    | 15.145947193  (-57.4%)
linearize-time              | 68.196633551    | 25.444779976  (-62.7%)

@AWoloszyn AWoloszyn requested review from ben-clayton and qining May 25, 2018 15:18
@AWoloszyn AWoloszyn merged commit 9c9efe4 into google:master May 25, 2018
@AWoloszyn AWoloszyn deleted the byte-slices branch May 25, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qining qining Awaiting requested review from qining

1 more reviewer

@ben-clayton ben-clayton ben-clayton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AWoloszyn @ben-clayton