[Kotlin] Fix nullability of generated Kotlin ByteBuffer accessors #8844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
given this is a kotlin PR, I'd like to see if we can fix our kotlin mac os job before reviewing/merging this. Hopefully it's as simple as updating to a later macos runner. |
Collaborator
|
see #8845 |
jtdavis777
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the generated Kotlin members for vector and string fields to have a nullable return type, unless the field is marked
(required):val <field>AsByteBuffer : ByteBufferfun <field>InByteBuffer(_bb: ByteBuffer) : ByteBufferThe goldens files are not affected by this PR.