Deprecate --ts-flat-files and --ts-entry-points
#8831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@jtdavis777 I'm not sure when I can find time to get into that stuff, also due to lack of motivation because as I see it these days bundling is fully handled by higher level tooling like https://vite.dev/. I see very little need to make standalone single file bundles of just generated flatbuffers ts code. Even if you make a library for reuse it would likely involve something more than the flatbuffers generated code only (this is my use case at https://github.com/flatgeobuf/flatgeobuf). |
bjornharrtell
approved these changes
Dec 8, 2025
Collaborator
Author
|
I suppose if this is a not super used feature, the necessity to document how to do it isn't that high. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8696
These two flags have no effect anymore - this change explicitly marks them as deprecated.
@bjornharrtell I think it would be good for us to still document somewhere how to run the esbuild steps you recommend -- deferring to you for what you think we need.