Skip to content

Conversation

@fawdlstty
Copy link
Contributor

Because the [#8380] author hasn't updated the working tree for a long time, I decided to reopen [#8259]

@github-actions github-actions bot added c++ codegen Involving generating code from schema dart labels Feb 25, 2025
@fawdlstty fawdlstty changed the title Fixed compilation failure caused by multi-layer references [dart] fix bug which generated wrong code Mar 4, 2025
@fawdlstty
Copy link
Contributor Author

@aardappel Hello, can you take some time to review it?

@aardappel
Copy link
Collaborator

Like the other PR, you need to include exactly all the changes this has on the test generated code files in this repo.

@fawdlstty
Copy link
Contributor Author

The test was modified by another author. I don't think I'm suitable to submit. Do you have any suggestions?

@fawdlstty
Copy link
Contributor Author

@insertjokehere Hello. Do you have time to resubmit your test modifications?

@aardappel
Copy link
Collaborator

You just need to run the script. If you look at the CI failures above, you'd see:

ERROR: ********************************************************
ERROR: * The following differences were found after running   *
ERROR: * the script/generate_code.py script. Maybe you forgot *
ERROR: * to run it after making changes in a generator?       *
ERROR: ********************************************************

@fawdlstty
Copy link
Contributor Author

fawdlstty commented May 16, 2025

I noticed that the error message was caused by the generation module of the Rust language and TypeScript language, but this patch did not modify that part. I think this question needs to be fixed in another patch, not here.

@github-actions
Copy link
Contributor

This pull request is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ codegen Involving generating code from schema dart stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants