Fixed native_type generating wrong C++ code. #8003
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
native_type generated C++ code that couldn't be compiled when used without native_inline.
Related to issue #6770, which never got fixed.
Before, a schema like this would generate code that couldn't be compiled:
Using the
Vector3Das an array or with the "native_inline" attribute did work as expected.I've added some code to the C++ generator to fix the issue so it works by itself. It has to create a
unique_ptrcorrectly when unpacking and de-referencing one when packing.I also added some test cases for the
native_type, one with thenative_inlineattribute and one without toNativeTypeTest.