optional scalars for ts/js #6215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2ccdb8 to
a6010cb
Compare
aardappel
reviewed
Oct 26, 2020
| */ | ||
| optional_scalars.ScalarStuff.prototype.maybeI8 = function() { | ||
| var offset = this.bb.__offset(this.bb_pos, 6); | ||
| return offset ? this.bb.readInt8(this.bb_pos + offset) : null; |
Collaborator
There was a problem hiding this comment.
hurray for dynamically typed languages, they make a null integer rather simple :)
Collaborator
|
LGTM |
Contributor
Author
|
merge? |
Collaborator
|
sure, I can push the merge button, once the conflict is resolved |
Contributor
Author
|
Again? I just resolved some :) |
Collaborator
|
yea it looks like the change was in .gitignore. No need to wait for tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #6014