MOE Sync 2020-04-28#1595
Merged
Merged
Conversation
e.g. java.util.function.Function, not arbitrary user-defined FI types, which may have more documentation value. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=308682538
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=308780548
…ry, rather than burying it in the details. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=308787678
Fixes #1432 Fixes #1439 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=308794942
Collaborator
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Only apply UnnecessaryLambda to FIs in core packages
e.g. java.util.function.Function, not arbitrary user-defined FI types,
which may have more documentation value.
2c0ad30
Add a check to suggest importing unnecessarily qualified names.
a29b13a
EqualsGetClass: call out violating symmetry as a problem in the summary, rather than burying it in the details.
3d1228d
Fix findIdent incompatibility with Java 13
Fixes #1432
Fixes #1439
af9e57c