Skip to content

Fix for #801: enable imports for sites that are using git submodules#837

Merged
LisaFC merged 1 commit intogoogle:masterfrom
deining:fix2
Jan 17, 2022
Merged

Fix for #801: enable imports for sites that are using git submodules#837
LisaFC merged 1 commit intogoogle:masterfrom
deining:fix2

Conversation

@deining
Copy link
Contributor

@deining deining commented Jan 17, 2022 •
edited
Loading

Unfortunately, #801 did not work as expected. This PR will fix these issues, sorry for any inconvenience caused!

Note:: Inside the [module] section, this fix makes use of the replacements configuration setting:

[module]
# imports should not apply for sites that are using git submodules 
replacements = "github.com/FortAwesome/Font-Awesome -> ., github.com/twbs/bootstrap -> ."

Replacements is available as of hugo version 0.77.

Currently the user guide states:

You need a recent extended version (we recommend version 0.75.0 or later) of Hugo

Therefore with this patch we are raising minimum required hugo version from 0.75 to 0.77 (mandatory now). I hope this is o.k.
This PR updates the user guide accordingly.

@deining deining changed the title Fixs for #801 Fix for #801 Jan 17, 2022
@deining deining changed the title Fix for #801 Fix for #801: enable imports for sites that are using git submodules Jan 17, 2022
@LisaFC
Copy link
Collaborator

LisaFC commented Jan 17, 2022

Thanks for the prompt fix!

@LisaFC LisaFC merged commit fbc516e into google:master Jan 17, 2022
@deining deining deleted the fix2 branch January 17, 2022 10:28
This was referenced Jan 17, 2022
Closed
Closed
@deining deining restored the fix2 branch January 17, 2022 19:41
@rogerioesteves
Copy link

rogerioesteves commented Jan 17, 2022 •
edited
Loading

When I added Docsy in my project the last version of docsy is not working. I get the error "Error: module "github.com/FortAwesome/Font-Awesome" not found".

Was fixed this problem? Whats the work around?

@deining
Copy link
Contributor Author

deining commented Jan 17, 2022

When I added Docsy in my project the last version of docsy is not working. I get the error "Error: module "github.com/FortAwesome/Font-Awesome" not found".

Was fixed this problem? Whats the work around?

Workaround:

  • navigate to your themes folder
  • create two new directory structures (empty directories):
mkdir -p github.com/twbs/bootstrap
mkdir -p github.com/FortAwesome/Font-Awesome

Does this cure your problem?

@deining deining deleted the fix2 branch November 5, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deining @LisaFC @rogerioesteves