Skip to content

Turning docsy theme into a hugo module#806

Merged
chalin merged 1 commit intogoogle:feature-hugo-modulefrom
deining:mod
Dec 17, 2021
Merged

Turning docsy theme into a hugo module#806
chalin merged 1 commit intogoogle:feature-hugo-modulefrom
deining:mod

Conversation

@deining
Copy link
Contributor

@deining deining commented Dec 15, 2021

@LisaFC: Can you please merge this PR into the feature branch? The merge will give me a commit hash that I can refer to in my future work in this feature branch. Thanks.

@deining
Copy link
Contributor Author

deining commented Dec 17, 2021

In order to make fast progress here, it were great if you could allow me to bypass pull request requirements for this feature branch. The GitHub docu about branch protection rules has more details on this. Thanks for looking into this.

@chalin chalin merged commit 196d995 into google:feature-hugo-module Dec 17, 2021
@chalin
Copy link
Collaborator

chalin commented Dec 17, 2021

Can you please merge this PR into the feature branch? The merge will give me a commit hash that I can refer to in my future work in this feature branch

Done!

@chalin
Copy link
Collaborator

chalin commented Dec 17, 2021

In order to make fast progress here, it were great if you could allow me to bypass pull request requirements for this feature branch

@emckean or @LisaFC will have to do this, I don't have the permissions.

@chalin
Copy link
Collaborator

chalin commented Dec 17, 2021

Paraphrasing from #796 (comment):

Why is assets/bootstrap/scss/vendor/_rfs.scss being brought in separately as opposed to getting it via the BS module?

For reference, here's the files source: https://github.com/twbs/bootstrap/blob/v4-dev/scss/vendor/_rfs.scss

@deining
Copy link
Contributor Author

deining commented Dec 17, 2021

Paraphrasing from #796 (comment):

Why is assets/bootstrap/scss/vendor/_rfs.scss being brought in separately as opposed to getting it via the BS module?

This is a workaround for a known bug in go language: since the file _rfs.scss is located in a directory with name vendor, it is not part of the module, though it should be. Since this bug won't fix, we have to workaround this, which is quite cumbersome, I'm still investigating what's the best way here. For the docsy example site and for the userguide in docsy's theme repo, I do have an acceptable solution. If users start their site from scratch, however, there is an extra step needed that is all but elegant. Still reflecting on this ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants