Use hugo.IsProduction to determine build environment for CSS and JS#651
Merged
LisaFC merged 1 commit intogoogle:masterfrom Aug 20, 2021
Merged
Conversation
This was referenced Aug 9, 2021
Closed
fdeaa96 to
a4f64cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: use
hugo.IsProductionto determine build environment (production or development) rather than.Site.IsServer, when deciding which kind of CSS and JS to generate (production-grade or not).Hugo supports two kinds of build contexts (or "environments" as they are called in the Hugo docs): development and production.
By default, hugo serves a development version of a site, and builds (to disk) a production version. You can change the default for either of these commands by using the -e flag. It can be very useful to build a development version of the site -- e.g., for offline analysis. We can't do this currently due to the use of
.Site.IsServerexpression in thehead-css.htmlandscripts.htmlpartials. This PR fixes the issue./cc @nate-double-u