add rel attribute to prevent clickjacking#330
Merged
LisaFC merged 1 commit intogoogle:masterfrom Aug 25, 2020
lpmi-13:fix_security_issue
Merged
add rel attribute to prevent clickjacking#330LisaFC merged 1 commit intogoogle:masterfrom lpmi-13:fix_security_issue
LisaFC merged 1 commit intogoogle:masterfrom
lpmi-13:fix_security_issue
Conversation
`noopener` and `noreferrer` both address clickjacking vulnerabilities on `target="_blank"`, though `noopener` isn't supported in some legacy browsers, while `noreferrer` is supported, and is ignored by more recent browsers. So adding both is currently the easiest way to support everything.
Contributor
Author
|
for reference, currently causing this security vulnerability in the kubernetes contributor website
|
Collaborator
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noopenerandnoreferrerboth address clickjacking vulnerabilities ontarget="_blank", thoughnoopenerisn't supported in some legacy browsers, whilenoreferreris supported, and is ignored by more recent browsers. So adding both is currently the easiest way to support everything.