npm install: get rid of platform dependent cp command#1797
npm install: get rid of platform dependent cp command#1797deining wants to merge 2 commits intogoogle:mainfrom
Conversation
92727bb to
4e8ad9f
Compare
chalin
left a comment
There was a problem hiding this comment.
Thanks for this PR! I'll take a look as soon as I can when back at the office the week of the 29th. In the meantime, could you ensure that all of the GH actions pass?
7ff10ab to
0fb00a7
Compare
All GH actions are passing now 😄. Looking forward to your comments! |
There was a problem hiding this comment.
Oh, I love this! ❤️✨ It is a much better solution, thanks for finding and proposing it @deining 🙏
Edit: oops, it doesn't work as expected :(
We need to drop assets/_vendor. I'll push that in and then merge if the tests still pass.
|
Unless I misunderstood, this PR is meant to offer a replacement solution for the files under |
Yes, correct. In an ideal world, we could drop
But world is not always ideal and (go) software has bugs. The bug that affects us in this case is mentioned here. And the corresponding mount instruction is here: Lines 45 to 48 in 91efe35 To make it short, unless we move |
|
The whole point of the Hmm, maybe #1806 offers a win-win solution. PTAL |
This PR follows up on the discussion we have had in #1793.
It alters the mount points for npm boostrap dependency. After this change, the platform dependent
cpcommand which does not run on linux, can be discarded, thus solving #1793.