Skip to content

Avoiding 'Illegal shortcode state' (Hugo v0.102.2)#1211

Merged
deining merged 2 commits intogoogle:mainfrom
deining:illegal-state-shortcode
Sep 2, 2022
Merged

Avoiding 'Illegal shortcode state' (Hugo v0.102.2)#1211
deining merged 2 commits intogoogle:mainfrom
deining:illegal-state-shortcode

Conversation

@deining
Copy link
Contributor

@deining deining commented Aug 31, 2022

This PR avoids an Ìllegal shortcode state`, thrown by Hugo version 0.102.x

@deining deining force-pushed the illegal-state-shortcode branch 2 times, most recently from df77087 to 91d543d Compare August 31, 2022 14:36
@deining deining requested a review from LisaFC August 31, 2022 14:46
@deining deining linked an issue Aug 31, 2022 that may be closed by this pull request
@deining deining added the shortcodes Hugo shortcodes label Aug 31, 2022
@deining deining force-pushed the illegal-state-shortcode branch from 91d543d to c8fb9b3 Compare August 31, 2022 20:21
@deining deining changed the title Avoiding 'Illegal shortcode state' (Hugo v0.102.1) Avoiding 'Illegal shortcode state' (Hugo v0.102.2) Aug 31, 2022
@deining
Copy link
Contributor Author

deining commented Sep 1, 2022

Rendering of user guide failed due to a regression introduced in hugo v0.102.0, fixed with recently released version hugo v0.102.3.
I would like to keep this PR open though, since the syntax cahnge of the shortcode make sit easier to read. I still think it is a good thing to merge this PR.

@LisaFC
Copy link
Collaborator

LisaFC commented Sep 2, 2022

Agree it's easier to read - I think we have some stuff in shortcodes (not sure about this one) that were added for compatibility with multiples of versions of Hugo ago.

@LisaFC
Copy link
Collaborator

LisaFC commented Sep 2, 2022

This version renders properly with the previous version of Hugo, right?

@deining
Copy link
Contributor Author

deining commented Sep 2, 2022

This version renders properly with the previous version of Hugo, right?

Yes, it I tested it with hugo v0.101 and v0.102.x, and the result was always fine.

@deining deining merged commit a917d9d into google:main Sep 2, 2022
@deining deining deleted the illegal-state-shortcode branch March 9, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shortcodes Hugo shortcodes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hugo v0.102.2: rendering of userguide fails

3 participants