Shortcodes for tabbed panes: improvements (allow textual content)#1009
Merged
geriom merged 1 commit intogoogle:mainfrom May 24, 2022
Merged
Shortcodes for tabbed panes: improvements (allow textual content)#1009geriom merged 1 commit intogoogle:mainfrom
geriom merged 1 commit intogoogle:mainfrom
Conversation
a4851dc to
4528a3a
Compare
Collaborator
|
Let me know when this is ready for review! |
4528a3a to
95ee1e9
Compare
Contributor
Author
This PR is ready for review now, I hope you like it. |
Collaborator
|
Awesome! I was actually trying to implement this same feature because we use a similar shortcode with a different name in Tekton. I''m going to TAL. |
geriom
requested changes
May 22, 2022
Collaborator
geriom
left a comment
There was a problem hiding this comment.
Great job. Thank you!
Just a couple of small suggestions.
geriom
requested changes
May 22, 2022
95ee1e9 to
628e05c
Compare
- allow tab content in markdown - tab header can now be given as unnamed parameter - tab(s) can now be disabled - improve storage of active language - new option to turn storage of active language off - improvements and fixes - documentation update
628e05c to
2ae4f62
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the shortcodes for tabbed panes:
This PR closes #936. It also closes #550.