Remove the 'android-classes' from Dagger's artifact transform to avoid ambiguity in transform chains with Gradle 9.0.0. #4933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a82a5a to
2746560
Compare
…d ambiguity in transform chains with Gradle 9.0.0. The use of the attribute is not needed as AGP setups enough transforms such that an android library (project or external) has an outgoing variant whose artifact type is 'jar'. This change also bumps the minimum required AGP version of the plugin from 8.1 to 8.4 as that is the minimum version where the removed attribute is no longer needed. Due to the AGP update the tests projects are also updated: * Gradle from 8.4 to 8.6 * AGP from 8.1.1 to 8.4.2 * Android build tools from 33.0.1 to 34.0.0 * Android compile and targets SDK from 33 to 34 Fixes #4847 RELNOTES=N/A PiperOrigin-RevId: 800424938
2746560 to
ea570e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the 'android-classes' from Dagger's artifact transform to avoid ambiguity in transform chains with Gradle 9.0.0.
The use of the attribute is not needed as AGP setups enough transforms such that an android library (project or external) has an outgoing variant whose artifact type is 'jar'.
This change also bumps the minimum required AGP version of the plugin from 8.1 to 8.4 as that is the minimum version where the removed attribute is no longer needed.
Due to the AGP update the tests projects are also updated:
Fixes #4847
RELNOTES=N/A