goog.object.unsafeClone now clones Date objects correctly.

12wrigja · copybara-github · commit 767dd4bbaf6f · 2022-09-13T11:38:05.000-07:00
Fixes #1175. RELNOTES: goog.object.unsafeClone now clones Date objects correctly. PiperOrigin-RevId: 474078524 Change-Id: I82a9a2af03baaf646cfdfad19da4fd0cf8163863
diff --git a/closure/goog/object/object.js b/closure/goog/object/object.js
@@ -454,6 +454,8 @@ function unsafeClone(obj) {
     return new Map(obj);
   } else if (typeof Set !== 'undefined' && obj instanceof Set) {
     return new Set(obj);
+  } else if (obj instanceof Date) {
+    return new Date(obj.getTime());
   }
   const clone = Array.isArray(obj) ? [] :
       typeof ArrayBuffer === 'function' &&
diff --git a/closure/goog/object/object_test.js b/closure/goog/object/object_test.js
@@ -268,6 +268,16 @@ testSuite({
     assertEquals(original.f, clone.f);
   },
 
+  testUnsafeCloneDates() {
+    const original = {d: new Date(5000)};
+    const clone = googObject.unsafeClone(original);
+
+    assertNotEquals(original, clone);
+    assertNotEquals(original.d, clone.d);
+    assertTrue(clone.d instanceof Date);
+    assertEquals(5000, clone.d.getTime());
+  },
+
   testForEach() {
     const m = getObject();
     let s = '';

Original file line number	Diff line number	Diff line change
`@@ -454,6 +454,8 @@ function unsafeClone(obj) {`
`454`	`454`	`return new Map(obj);`
`455`	`455`	`} else if (typeof Set !== 'undefined' && obj instanceof Set) {`
`456`	`456`	`return new Set(obj);`
	`457`	`+ } else if (obj instanceof Date) {`
	`458`	`+ return new Date(obj.getTime());`
`457`	`459`	`}`
`458`	`460`	`const clone = Array.isArray(obj) ? [] :`
`459`	`461`	`typeof ArrayBuffer === 'function' &&`