Restore ES6 module processing of input#2637
Closed
thelgevold wants to merge 1 commit intogoogle:masterfrom
Closed
Conversation
Contributor
|
@blickly I thought this was fixed? |
Contributor
|
The reason this was originally changed was that anytime ES6 or higher was specified as the input language, a full parse of every input file was required. We don't want to undo that fix. I'm closing this in favor of #2641 - but it may take a bit to get that one landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this I am proposing a fix to a problem we have been having when integrating Angular builds with versions of Closure Compiler > 20170409.0.0.
It appears that Input processing of ES6 modules was removed in the following commit: d24d175
Putting parts of this back fixes the issue.
The test repo for this can be found here: https://github.com/angular/closure-demo
Some of the input files in the flag file are written in ES6 JavaScript (all the Angular bundles).
With the current release of CC the ES6 input files are not resolved. The compilation fails with errors messages like:
cc: @alexeagle