Refactor issuance chain service#1512
Merged
mhutchinson merged 1 commit intogoogle:masterfrom Jun 25, 2024
Merged
Conversation
Primary goal is to have 2 separate implementations of the different services, instead of having both implementations inside the same class with conditional switching. This is realized by introducing a _direct_ chain service that performs the legacy implementation of storing chains directly inside the extra data in Trillian. The logic for the new feature is now in an _indirect_ chain service that requires the storage and cache that chains are stored in.
Contributor
|
I'm OOO from tomorrow and next week, I'll have a look when I'm back. |
roger2hk
approved these changes
Jun 21, 2024
Contributor
roger2hk
left a comment
There was a problem hiding this comment.
Thanks Martin. The issuance chain service and the log leaf builder are now structured in a better way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary goal is to have 2 separate implementations of the different services, instead of having both implementations inside the same class with conditional switching. This is realized by introducing a direct chain service that performs the legacy implementation of storing chains directly inside the extra data in Trillian. The logic for the new feature is now in an indirect chain service that requires the storage and cache that chains are stored in.