Merged
Conversation
jsoref
commented
Sep 8, 2023
Comment on lines
-167
to
+169
| `start` and `end` parameters and thereby increase the cachability of | ||
| `start` and `end` parameters and thereby increase the cacheability of |
Contributor
Author
There was a problem hiding this comment.
some projects don't like retroactively changing changelogs. Happy to drop this or anything else.
Comment on lines
128
to
+129
| URL: "uncollectable-roots/log/", | ||
| DNS: "uncollectavle.ct.googleapis.com", | ||
| DNS: "uncollectable.ct.googleapis.com", |
Contributor
Author
There was a problem hiding this comment.
It's possible this was intentional, but I'm hoping it isn't and doesn't matter...
| } | ||
|
|
||
| // Cancel any pending Log-requests for which there're no more awaiting | ||
| // Cancel any pending Log-requests for which there are no more awaiting |
Contributor
Author
There was a problem hiding this comment.
I don't think the abbreviation adds any value. There are on the order of 1000x more uses of the expansion than the contraction according to a Google search...
| } | ||
| // Now we have seen all fields in the structure, check that all select(Enum) {..} selector | ||
| // fields found a source field get get their data from. | ||
| // fields found a source field to get their data from. |
Contributor
Author
There was a problem hiding this comment.
this is an atypical correction (normally x x => x)
|
|
||
| IMPORTANT: Only code rooted within this part of the tree should refer to the CT | ||
| Github repository. Other parts of the system must not assume that the data they're | ||
| GitHub repository. Other parts of the system must not assume that the data they're |
AlCutter
reviewed
Sep 11, 2023
Comment on lines
128
to
+129
| URL: "uncollectable-roots/log/", | ||
| DNS: "uncollectavle.ct.googleapis.com", | ||
| DNS: "uncollectable.ct.googleapis.com", |
| lockDir = flag.String("lock_file_path", "/migrillian/master", "etcd lock file directory path") | ||
| electionDelay = flag.Duration("election_delay", 0, "Max random pause before participating in master election") | ||
| backend = flag.String("backend", "", "GRPC endpoing to connect to Trillian logservers") | ||
| backend = flag.String("backend", "", "GRPC endpoint to connect to Trillian logservers") |
Member
There was a problem hiding this comment.
I am sad that "endpoing" is not a word - I hereby coin this term to mean an RPC interface which is only ever used to check if a service is alive. :)
AlCutter
approved these changes
Sep 12, 2023
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Contributor
Author
|
@AlCutter: done |
Member
|
Thanks again, @jsoref! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/certificate-transparency-go/actions/runs/6126929463/attempts/1#summary-
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/certificate-transparency-go/actions/runs/6126929623#summary-16631876099
Checklist