Fix the optional type name and type identifier resolution#870
Merged
TristonianJones merged 1 commit intogoogle:masterfrom Jan 7, 2024
Merged
Fix the optional type name and type identifier resolution#870TristonianJones merged 1 commit intogoogle:masterfrom
TristonianJones merged 1 commit intogoogle:masterfrom
Conversation
l46kok
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
type(<optional>)the expected output would beoptional; however, this failssince the name
optionalis part of the namespace. To ensure optionals are type-testable,the type name has been shifted to
optional_type. This should not break anyone unless youare explicitly querying the type name as part of your implementation.
Additionally, this fix revealed a different issue wherein type identifiers were not being resolved
during type-check unless they were for structured object types. This change introduces a call
to
FindIdentwhich is also the same call being made at runtime to resolve type identifiersduring evaluation.