You're going to hate me, but I thought we were renaming MachineSpec -> MachineInfo to better lineup with ContainerInfo :)

@vmarmol Ah. That's fine. It's just some scripting work.

The problem in kubernetes/kubernetes#491 is that we have three functions in kubelet:

• GetContainerInfo(): This will return a container's info, same as in cAdvisor. So the return type of this method is info.ContainerInfo.
• GetMachineInfo(): This will return the root container's info. So it returns an info.ContainerInfo as well.
• GetMachineSpec(): This method returns the machine specification (number of cores, memory capacity). But the return type is info.MachineInfo, which may be confused with GetMachineInfo().

Any suggestion to solve this problem? Or you think it's fine?

What about calling GetMachineInfo() GetRootInfo() since we are returning a
ContainerInfo

On Thu, Jul 17, 2014 at 9:58 AM, monnand notifications@github.com wrote:

@vmarmol https://github.com/vmarmol Ah. That's fine. It's just some
scripting work.

The problem in kubernetes/kubernetes#491
kubernetes/kubernetes#491 is that we
have three functions in kubelet:

• GetContainerInfo(): This will return a container's info, same as in
  cAdvisor. So the return type of this method is info.ContainerInfo.
• GetMachineInfo(): This will return the root container's info. So it
  returns an info.ContainerInfo as well.
• GetMachineSpec(): This method returns the machine specification
  (number of cores, memory capacity). But the return type is
  info.MachineInfo, which may be confused with GetMachineInfo().

Any suggestion to solve this problem? Or you think it's fine?

—
Reply to this email directly or view it on GitHub
#92 (comment).

That would be fine I think. Thank you @vmarmol.

Close this issue and will work on kubernetes/kubernetes#491.