Skip to content

Dollar signs not escaped in generated toString() #784

@terrier989

Description

@terrier989

Classes like:

class Example {
  String get $notEscaped;
}

Generate:

  @override
  String toString() {
    return (newBuiltValueToStringHelper('Example')
          ..add('$notEscaped', notEscaped))
        .toString();
 }

The bug is in value_source_class.dart:

    if (!implementsToString) {
      result.writeln('@override');
      result.writeln('String toString() {');
      if (fields.isEmpty) {
        result
            .writeln("return newBuiltValueToStringHelper('$name').toString();");
      } else {
        result.writeln("return (newBuiltValueToStringHelper('$name')");
        result.writeln(fields
            .map((field) => "..add('${field.name}',  ${field.name})")
            .join(''));
        result.writeln(').toString();');
      }
      result.writeln('}');
      result.writeln();
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions