Skip to content

Fixed bug block is not unhighlighted#2580

Closed
kyoncy wants to merge 2 commits intoRaspberryPiFoundation:developfrom
kyoncy:fix/setHighlighted
Closed

Fixed bug block is not unhighlighted#2580
kyoncy wants to merge 2 commits intoRaspberryPiFoundation:developfrom
kyoncy:fix/setHighlighted

Conversation

@kyoncy
Copy link

@kyoncy kyoncy commented Jun 20, 2019

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

N/A

Proposed Changes

The only current-executed blocks should be highlighted but are not cleared so finally all the blocks are lit on only when they run the program on IE10/11.

after

Reason for Changes

In Japan many online materials of STEM classes for elementary schools are based on Google Blockly, so the case where children use Goolgle Blockly is not rare. Moreover most of Japanese schools are not equipped with Chrome/ Microsoft Edge nor Safari. They use Internet Explorer, even though IE has not supported.
We would like to make it clear to children that which code is to debag.

https://blockly-demo.appspot.com/static/demos/interpreter/step-execution.html
before

Test Coverage

Tested on:

  • Desktop Chrome
  • Desktop Firefox
  • Desktop Safari
  • Desktop Opera
  • Windows Internet Explorer 10
  • Windows Internet Explorer 11
  • Windows Edge

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kyoncy
Copy link
Author

kyoncy commented Jun 20, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kyoncy
Copy link
Author

kyoncy commented Jun 27, 2019

NeilFraser pushed a commit that referenced this pull request Jun 28, 2019
This is a rework of PR #2580.
@NeilFraser NeilFraser mentioned this pull request Jun 28, 2019
3 tasks
NeilFraser pushed a commit that referenced this pull request Jun 28, 2019
This is a rework of PR #2580.
@NeilFraser
Copy link
Contributor

Thanks for pointing out the bug in IE, and providing a solution. I've submitted PR #2598 which properly handles making the highlight path appear and disappear.

@NeilFraser NeilFraser closed this Jun 28, 2019
@kyoncy kyoncy deleted the fix/setHighlighted branch July 25, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants