Fixed bug block is not unhighlighted#2580
Fixed bug block is not unhighlighted#2580kyoncy wants to merge 2 commits intoRaspberryPiFoundation:developfrom kyoncy:fix/setHighlighted
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
https://github.com/google/blockly/pull/2580/files#diff-fd04c06f310c3ed628154e399e570c9cR1197 |
This is a rework of PR #2580.
This is a rework of PR #2580.
|
Thanks for pointing out the bug in IE, and providing a solution. I've submitted PR #2598 which properly handles making the highlight path appear and disappear. |
The basics
The details
Resolves
N/A
Proposed Changes
The only current-executed blocks should be highlighted but are not cleared so finally all the blocks are lit on only when they run the program on IE10/11.
Reason for Changes
In Japan many online materials of STEM classes for elementary schools are based on Google Blockly, so the case where children use Goolgle Blockly is not rare. Moreover most of Japanese schools are not equipped with Chrome/ Microsoft Edge nor Safari. They use Internet Explorer, even though IE has not supported.
We would like to make it clear to children that which code is to debag.
https://blockly-demo.appspot.com/static/demos/interpreter/step-execution.html

Test Coverage
Tested on: