review notes

LebedevRI · LebedevRI · commit 5c9a54ff98db · 2019-04-08T21:31:22.000+03:00
diff --git a/include/benchmark/benchmark.h b/include/benchmark/benchmark.h
@@ -875,7 +875,7 @@ class Benchmark {
   Benchmark* DisplayAggregatesOnly(bool value = true);
 
   // By default, the CPU time is measured only for the main thread, which may
-  // be unrepresentable if the benchmark uses threads internally. If called,
+  // be unrepresentative if the benchmark uses threads internally. If called,
   // the total CPU time spent by all the threads will be measured instead.
   // By default, the only the main thread CPU time will be measured.
   Benchmark* MeasureProcessCPUTime();
diff --git a/src/benchmark_runner.cc b/src/benchmark_runner.cc
@@ -111,7 +111,10 @@ BenchmarkReporter::Run CreateRunReport(
 // Adds the stats collected for the thread into *total.
 void RunInThread(const BenchmarkInstance* b, size_t iters, int thread_id,
                  ThreadManager* manager) {
-  internal::ThreadTimer timer(b->measure_process_cpu_time);
+  internal::ThreadTimer timer(
+      b->measure_process_cpu_time
+          ? internal::ThreadTimer::CreateProcessCpuTime()
+          : internal::ThreadTimer::Create());
   State st = b->Run(iters, thread_id, &timer, manager);
   CHECK(st.iterations() >= st.max_iterations)
       << "Benchmark returned before State::KeepRunning() returned false!";
diff --git a/src/thread_timer.h b/src/thread_timer.h
@@ -8,10 +8,17 @@ namespace benchmark {
 namespace internal {
 
 class ThreadTimer {
- public:
-  ThreadTimer(bool measure_process_cpu_time_)
+  explicit ThreadTimer(bool measure_process_cpu_time_)
       : measure_process_cpu_time(measure_process_cpu_time_) {}
 
+ public:
+  static ThreadTimer Create() {
+    return ThreadTimer(/*measure_process_cpu_time_=*/false);
+  }
+  static ThreadTimer CreateProcessCpuTime() {
+    return ThreadTimer(/*measure_process_cpu_time_=*/true);
+  }
+
   // Called by each thread
   void StartTimer() {
     running_ = true;
