Skip to content

Conversation

@andrewheard
Copy link
Collaborator

Renamed getTokenForcingRefresh:completion: to tokenForcingRefresh:completion and getLimitedUseTokenWithCompletion: to limitedUseTokenWithCompletion: since they behave like the public API methods of the same names in Firebase App Check (rather than the interop methods).

Renamed `getTokenForcingRefresh:completion:` to `tokenForcingRefresh:completion` and
`getLimitedUseTokenWithCompletion:` to `limitedUseTokenWithCompletion:` since they behave like the
public API methods of the same names in Firebase App Check (rather than the interop names).
@andrewheard andrewheard marked this pull request as ready for review August 22, 2023 21:37
@andrewheard andrewheard requested a review from paulb777 August 22, 2023 21:37
@andrewheard andrewheard merged commit f85d46b into main Aug 22, 2023
@andrewheard andrewheard deleted the ah/remove-get-prefix branch August 22, 2023 22:08
@andrewheard
Copy link
Collaborator Author

cc: @mdmathias Once you update your AppCheckCore dependency to 0.1.0-alpha.4 you'll need to change getLimitedUseTokenWithCompletion: to limitedUseTokenWithCompletion: on line https://github.com/google/GoogleSignIn-iOS/blob/18b5fbe51adcef2d38d539f1693adbf15875bb1c/GoogleSignIn/Sources/GIDAppCheck/Implementations/GIDAppCheck.m#L142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants