fix: validate user_id and session_id against path traversal in FileArtifactService#5206
Closed
enjoykumawat wants to merge 3 commits into
Closed
fix: validate user_id and session_id against path traversal in FileArtifactService#5206enjoykumawat wants to merge 3 commits into
enjoykumawat wants to merge 3 commits into
Conversation
…tifactService FileArtifactService validated filenames for path traversal but used user_id and session_id directly in Path() construction without validation. A user_id or session_id containing ../ segments could escape the root_dir. Add _validate_path_segment() to reject path separators (/, \) and traversal sequences (..) in these parameters. Fixes google#5110
9957c52 to
cd9cd6b
Compare
Collaborator
|
Hi @enjoykumawat , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix failing mypy-diff tests before we can proceed with a review. |
Collaborator
|
Hi @enjoykumawat , closing this since it has been fixed in this commit. cbcb5e6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_validate_path_segment()to reject path separators and traversal sequences inuser_idandsession_idFileArtifactServiceaffected — GCS and InMemory use string keysRoot Cause
_resolve_scoped_artifact_pathvalidates filenames butuser_id/session_idwere used directly inPath()construction. Auser_idcontaining../could escaperoot_dir.Test Plan
../in user_id/session_id now raises ValueErrorFixes #5110