fix(core): replace 'any' with typed AuthConfig in EventActions#405
Merged
kalenkevich merged 2 commits intoJun 8, 2026
Merged
Conversation
kalenkevich
approved these changes
Jun 8, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Problem:
The
AuthConfigtype inEventActions(defined incore/src/events/event_actions.ts) was typed asanywith aTODO: b/425992518. This lacked proper type safety and permitted incorrect assignments elsewhere in the codebase.Solution:
Replaced
anywith the properAuthConfigimport from../auth/auth_tool.js.To resolve resulting TypeScript compiler errors:
requestedAuthConfigsas an empty object{}instead of an empty array[]inside the default actions block oftoken_based_context_compactor.ts.AuthConfigand castactions.requestedAuthConfigsasRecord<string, AuthConfig>(rather thanRecord<string, unknown>) invertex_ai_session_service.ts.Testing Plan
Unit Tests:
Summary of passed npm test results:
npm run test:unitlocally.Manual End-to-End (E2E) Tests:
Verified that compiling the workspaces via
npm run buildsucceeds without any TypeScript diagnostic errors (which previously failed ontscwithTS2322).Checklist
Additional context
Addresses
TODO: b/425992518 - Replace 'any' with a proper AuthConfig.