[v10] Fix '[FBLPromise HTTPBody]' SwiftUI Preview crash]#146
Merged
Conversation
ncooke3
commented
Jul 19, 2024
Coverage Report 1Affected Products
Test Logs |
paulb777
reviewed
Jul 19, 2024
paulb777
approved these changes
Jul 19, 2024
paulb777
reviewed
Jul 23, 2024
paulb777
approved these changes
Jul 23, 2024
paulb777
left a comment
Member
There was a problem hiding this comment.
Would you update release note and minor version update here or in the follow up PR?
Member
Author
Nevermind 🤦 |
Member
Author
|
Merged. Tagging |
|
H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that this category was likely not being linked in SwiftUI previews mode. So, I programmatically force linked it with a C function. The crash was a little different thereafter, but the root problem remained the same, the request promise was not resolving and the object remained of type FBLPromise rather than the GDTURLResponse type (which lead to the crash when it tried to send a GDTURLResponse instance method message to an object of type FBLPromise). Deleting the NSURLSession category and moving the code inline worked. This was the only usage of the category so I think this works out fine.
Fix firebase/firebase-ios-sdk#13318
Fix firebase/firebase-ios-sdk#12581
Fix firebase/firebase-ios-sdk#11733