Skip to content

Conversation

@Nezz
Copy link
Contributor

@Nezz Nezz commented Jan 21, 2015

As discussed in #246

@Nezz
Copy link
Contributor Author

Nezz commented Jan 21, 2015

Should I submit this to master or dev?

@ojw28
Copy link
Contributor

ojw28 commented Jan 21, 2015

It'll need submitting into dev. You'll also need to sign the appropriate CLA before we can merge the change. See:

https://github.com/google/ExoPlayer/blob/master/CONTRIBUTING.md

Thanks!

@CCorrado
Copy link

CCorrado commented Jun 4, 2017

Was this PR not included in r.2.4.1 ? Looking for the proper way to use FileDescriptor (instead of a URI) with ExoPlayer, this is a perfect solution. Not seeing "FrameworkSampleSource" or another MediaSource implementation that takes in a FD instead of URI.

@ojw28
Copy link
Contributor

ojw28 commented Jun 5, 2017

FrameworkSampleSource is not part of ExoPlayer V2, since we removed all our dependencies on Android's MediaExtractor API. It's probably best if you file a new issue/question explaining what you're actually trying to do (in terms of what the use case is, rather than "I want to use a FileDescriptor"). There may well be an easy alternative or better way of doing whatever you're trying to do.

@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants