Fix the compilation of some downstream intra-process packages.#10
Closed
clalancette wants to merge 2 commits intogonzodepedro:gonzo/non-transform-intra-process-working-testsfrom
Conversation
In particular, the fixes in here make it so that the tlsf_cpp package can now compile. What's going on in this PR is that we are being more careful with using the template type that the user passed in, and passing that along as appropriate. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Collaborator
Author
|
I'm closing this for now because I think we are going in a different direction. We can always reopen later if we need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, the fixes in here make it so that the tlsf_cpp
package can now compile. What's going on in this PR is that
we are being more careful with using the template type that
the user passed in, and passing that along as appropriate.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org