Skip to content

interp: add not-a-knot cubic spline interpolator#1679

Merged
romanwerpachowski merged 5 commits intogonum:masterfrom
romanwerpachowski:not-a-knot
Jun 23, 2021
Merged

interp: add not-a-knot cubic spline interpolator#1679
romanwerpachowski merged 5 commits intogonum:masterfrom
romanwerpachowski:not-a-knot

Conversation

@romanwerpachowski
Copy link
Contributor

Please take a look.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2021

Codecov Report

Merging #1679 (a1bc35c) into master (f2a128f) will increase coverage by 0.00%.
The diff coverage is 94.59%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1679   +/-   ##
=======================================
  Coverage   73.27%   73.28%           
=======================================
  Files         507      507           
  Lines       60004    60028   +24     
=======================================
+ Hits        43970    43992   +22     
- Misses      13553    13554    +1     
- Partials     2481     2482    +1     
Impacted Files Coverage Δ
interp/cubic.go 97.52% <94.59%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a128f...a1bc35c. Read the comment docs.

@romanwerpachowski
Copy link
Contributor Author

How can I diagnose the build errors? It builds fine locally, and when I go to https://travis-ci.com/github/gonum/gonum/jobs/516634472 all I see in logs is "Automatic restarts limited: Please try restarting this job later or contact support@travis-ci.com."

@kortschak
Copy link
Member

Don't worry about travis. I can do local arm64 builds if you want. We have nearly run out of build minutes there and they are not very responsive.

@romanwerpachowski
Copy link
Contributor Author

Thanks. I think ARM will have the same FP precision as Intel so no need to adjust the tolerances for unit tests?

@kortschak
Copy link
Member

I'll take a look. For the most part the precision is the same. The differences, when they happen, are in numerically unstable functions due to differences in operation ordering and the fact that the arm64 code generation emits FMA and FMS instructions when it can while the amd64 doesn't.

@romanwerpachowski
Copy link
Contributor Author

romanwerpachowski commented Jun 21, 2021 via email

@romanwerpachowski
Copy link
Contributor Author

ping

@kortschak kortschak changed the title interp: Add not-a-knot cubic spline interpolator. interp: add not-a-knot cubic spline interpolator Jun 21, 2021
@romanwerpachowski romanwerpachowski merged commit 32fa687 into gonum:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants