interp: add not-a-knot cubic spline interpolator#1679
interp: add not-a-knot cubic spline interpolator#1679romanwerpachowski merged 5 commits intogonum:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
=======================================
Coverage 73.27% 73.28%
=======================================
Files 507 507
Lines 60004 60028 +24
=======================================
+ Hits 43970 43992 +22
- Misses 13553 13554 +1
- Partials 2481 2482 +1
Continue to review full report at Codecov.
|
|
How can I diagnose the build errors? It builds fine locally, and when I go to https://travis-ci.com/github/gonum/gonum/jobs/516634472 all I see in logs is "Automatic restarts limited: Please try restarting this job later or contact support@travis-ci.com." |
|
Don't worry about travis. I can do local arm64 builds if you want. We have nearly run out of build minutes there and they are not very responsive. |
|
Thanks. I think ARM will have the same FP precision as Intel so no need to adjust the tolerances for unit tests? |
|
I'll take a look. For the most part the precision is the same. The differences, when they happen, are in numerically unstable functions due to differences in operation ordering and the fact that the arm64 code generation emits FMA and FMS instructions when it can while the amd64 doesn't. |
|
Thanks!
…On Mon, 21 Jun 2021 at 01:24, Dan Kortschak ***@***.***> wrote:
All good.
TASK [Run tests on gonum.org/v1/gonum/interp in not-a-knot branch.] ************************************
changed: [bildr.fritz.box]
PLAY RECAP *********************************************************************************************
bildr.fritz.box : ok=2 changed=2 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
|
|
ping |
Please take a look.