Skip to content

lapack: add Dlag2 subroutine#1665

Closed
soypat wants to merge 5 commits intogonum:masterfrom
soypat:dlag2
Closed

lapack: add Dlag2 subroutine#1665
soypat wants to merge 5 commits intogonum:masterfrom
soypat:dlag2

Conversation

@soypat
Copy link
Contributor

@soypat soypat commented Jun 13, 2021

ARE issue #1651

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #1665 (1353c54) into master (c8613b2) will increase coverage by 0.07%.
The diff coverage is 80.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
+ Coverage   73.21%   73.29%   +0.07%     
==========================================
  Files         503      508       +5     
  Lines       59798    60136     +338     
==========================================
+ Hits        43782    44076     +294     
- Misses      13536    13569      +33     
- Partials     2480     2491      +11     
Impacted Files Coverage Δ
lapack/gonum/dlag2.go 80.30% <80.30%> (ø)
optimize/listsearch.go 72.22% <0.00%> (-1.86%) ⬇️
interp/cubic.go 98.16% <0.00%> (-1.84%) ⬇️
mat/band.go 70.64% <0.00%> (ø)
graph/formats/rdf/urna.go 97.44% <0.00%> (ø)
graph/formats/rdf/iso_canonical.go 78.73% <0.00%> (ø)
graph/encoding/encoding.go 100.00% <0.00%> (ø)
stat/distuv/chi.go 93.33% <0.00%> (ø)
lapack/gonum/dgesc2.go 61.29% <0.00%> (ø)
lapack/gonum/dgetc2.go 75.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8613b2...1353c54. Read the comment docs.

@soypat soypat mentioned this pull request Jun 14, 2021
@soypat
Copy link
Contributor Author

soypat commented Jun 26, 2021

ping

@vladimir-ch
Copy link
Member

Let's first get Dorgr2 done, only little left to do there.

@kortschak
Copy link
Member

Given the limited bandwidth available for review, the optimal approach to ordering work in a complex addition like this is a strict dependency ordering, only moving on to dependent packages once dependencies have been accepted and merged; this reduces the overall cognitive load on reviewers since it ceases to be necessary to hold more than one package in mind at a time. Having too many things in the air will hamper progress rather than help it.

@soypat
Copy link
Contributor Author

soypat commented Jun 27, 2021

Having too many things in the air will hamper progress rather than help it.

This has started to become painfully apparent.

the optimal approach to ordering work in a complex addition like this is a strict dependency ordering

Sounds good. A slow but methodical and precise approach.

@soypat
Copy link
Contributor Author

soypat commented Sep 13, 2021

closed due to branch mismanagement.

@soypat soypat closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants