Skip to content

interp: add ClampedCubic interpolator#1662

Merged
romanwerpachowski merged 9 commits intogonum:masterfrom
romanwerpachowski:roman/clamped-cubic-spline
Jun 14, 2021
Merged

interp: add ClampedCubic interpolator#1662
romanwerpachowski merged 9 commits intogonum:masterfrom
romanwerpachowski:roman/clamped-cubic-spline

Conversation

@romanwerpachowski
Copy link
Contributor

Please take a look.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021

Codecov Report

Merging #1662 (273f14d) into master (4bb8d02) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1662   +/-   ##
=======================================
  Coverage   73.24%   73.25%           
=======================================
  Files         506      506           
  Lines       59953    59973   +20     
=======================================
+ Hits        43911    43931   +20     
  Misses      13556    13556           
  Partials     2486     2486           
Impacted Files Coverage Δ
interp/cubic.go 98.16% <100.00%> (+0.66%) ⬆️
optimize/listsearch.go 72.22% <0.00%> (-1.86%) ⬇️
graph/formats/rdf/urna.go 97.44% <0.00%> (ø)
graph/formats/rdf/iso_canonical.go 78.73% <0.00%> (ø)
graph/formats/rdf/rdf.go 78.26% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb8d02...273f14d. Read the comment docs.

@romanwerpachowski
Copy link
Contributor Author

PTAL.

@soypat
Copy link
Contributor

soypat commented Jun 13, 2021

Where do the want values come from? Could we not make property based tests?

@romanwerpachowski
Copy link
Contributor Author

They come from scipy.interpolate.CubicSpline, which I treat as a trusted reference implementation until proven otherwise :) I could test properties of ClampedCubic directly, but it's more work and the current test is sufficient IMHO.

@romanwerpachowski
Copy link
Contributor Author

ping

@romanwerpachowski romanwerpachowski merged commit e102cf2 into gonum:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants