interp: Add NaturalCubic spline interpolator#1657
Merged
romanwerpachowski merged 19 commits intogonum:masterfrom Jun 11, 2021
Merged
interp: Add NaturalCubic spline interpolator#1657romanwerpachowski merged 19 commits intogonum:masterfrom
romanwerpachowski merged 19 commits intogonum:masterfrom
Conversation
added 13 commits
February 20, 2021 16:42
added 2 commits
June 8, 2021 09:59
Codecov Report
@@ Coverage Diff @@
## master #1657 +/- ##
==========================================
+ Coverage 73.22% 73.24% +0.01%
==========================================
Files 504 506 +2
Lines 59815 59953 +138
==========================================
+ Hits 43798 43910 +112
- Misses 13537 13557 +20
- Partials 2480 2486 +6
Continue to review full report at Codecov.
|
kortschak
reviewed
Jun 9, 2021
Contributor
Author
|
PTAL. |
Contributor
Author
|
PTAL. |
kortschak
previously approved these changes
Jun 10, 2021
Member
kortschak
left a comment
There was a problem hiding this comment.
LGTM, but please wait for @vladimir-ch.
Contributor
Author
|
@vladimir-ch ping :) |
vladimir-ch
reviewed
Jun 11, 2021
Member
vladimir-ch
left a comment
There was a problem hiding this comment.
I took a quick look, I won't have time to go through the code in detail.
vladimir-ch
reviewed
Jun 11, 2021
Contributor
Author
|
PTAL. |
vladimir-ch
approved these changes
Jun 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's about time :)