Merged
Conversation
stevenh
requested changes
Feb 11, 2024
Collaborator
stevenh
left a comment
There was a problem hiding this comment.
Thanks for the PR appreciated.
I've done a quick pass, some minor nits to clean up, will do another pass once those are addressed.
71165fd to
fa1f1b6
Compare
Contributor
Author
|
@stevenh, thanks, all comments are processed. Please review again:) |
Collaborator
stevenh
requested changes
Feb 20, 2024
Collaborator
stevenh
left a comment
There was a problem hiding this comment.
So apparently I didn't hit submit on this, so apologies its a been a while.
Add TestOnBorrowContext to the Pool struct for checking the health of the idle connection with a given context.
fa1f1b6 to
312b6db
Compare
stevenh
approved these changes
Feb 20, 2024
Collaborator
|
Thanks for your work on this @vasayxtx appreciated! |
Contributor
Author
|
@stevenh, no problem, thank you for the review!:) |
mraerino
referenced
this pull request
in ffddorf/terraform-backend
Apr 28, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/gomodule/redigo](https://togithub.com/gomodule/redigo) | `v1.8.9` -> `v1.9.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>gomodule/redigo (github.com/gomodule/redigo)</summary> ### [`v1.9.2`](https://togithub.com/gomodule/redigo/releases/tag/v1.9.2) [Compare Source](https://togithub.com/gomodule/redigo/compare/v1.9.1...v1.9.2) <a name='v1.9.2'></a> ##### v1.9.2 Release Notes (2024-02-25T12:54:41Z) #### Changelog ##### Bug fixes - [`e05a63b`](https://togithub.com/gomodule/redigo/commit/e05a63bfd93c1db480ee706c1686d9dd2385016b): fix: bump go version to 1.17 ([#​666](https://togithub.com/gomodule/redigo/issues/666)) ([@​stevenh](https://togithub.com/stevenh)) ##### Continuous Integration - [`4c535aa`](https://togithub.com/gomodule/redigo/commit/4c535aa56d60a1dddd457a8e63caa463bcb5a70b): ci: fix go caching ([#​667](https://togithub.com/gomodule/redigo/issues/667)) ([@​stevenh](https://togithub.com/stevenh)) [Full Changelog](https://togithub.com/gomodule/redigo/compare/v1.9.1...v1.9.2) ### [`v1.9.1`](https://togithub.com/gomodule/redigo/releases/tag/v1.9.1) [Compare Source](https://togithub.com/gomodule/redigo/compare/v1.9.0...v1.9.1) <a name='v1.9.1'></a> ##### v1.9.1 Release Notes (2024-02-20T23:51:27Z) #### Changelog ##### Chores - [`162ed02`](https://togithub.com/gomodule/redigo/commit/162ed022a35991830c265f24896b07d6537b3702): chore: retract v1.8.10 ([#​664](https://togithub.com/gomodule/redigo/issues/664)) ([@​stevenh](https://togithub.com/stevenh)) ##### Continuous Integration - [`cfabb1f`](https://togithub.com/gomodule/redigo/commit/cfabb1f017433cdf852a4841a8c0125c48275c0b): ci: remove deprecated goreleaser option ([#​663](https://togithub.com/gomodule/redigo/issues/663)) ([@​stevenh](https://togithub.com/stevenh)) [Full Changelog](https://togithub.com/gomodule/redigo/compare/v1.9.0...v1.9.1) ### [`v1.9.0`](https://togithub.com/gomodule/redigo/releases/tag/v1.9.0) <a name='v1.9.0'></a> ##### v1.9.0 Release Notes (2024-02-20T21:32:43Z) #### Changelog ##### Features - [`1d393b3`](https://togithub.com/gomodule/redigo/commit/1d393b301b27d4934d4b76ff4df60859e296cdec): feat: add TestOnBorrowContext ([#​660](https://togithub.com/gomodule/redigo/issues/660)) ([@​vasayxtx](https://togithub.com/vasayxtx)) ##### Bug fixes - [`78e255f`](https://togithub.com/gomodule/redigo/commit/78e255f9bd2ae9c9885793a751f42f5698a5da8c): fix: test goroutine leaks ([#​643](https://togithub.com/gomodule/redigo/issues/643)) ([@​stevenh](https://togithub.com/stevenh)) ##### Chores - [`9f0d2e9`](https://togithub.com/gomodule/redigo/commit/9f0d2e92e55d22b4c6d05bf8528ae90ed7fea855): chore: remove debug check ([#​659](https://togithub.com/gomodule/redigo/issues/659)) ([@​stevenh](https://togithub.com/stevenh)) - [`8b1c13e`](https://togithub.com/gomodule/redigo/commit/8b1c13e0376bc43a2443a0b312567718b4afbcd9): chore: run test server with enable-debug-command ([#​654](https://togithub.com/gomodule/redigo/issues/654)) ([@​elboulangero](https://togithub.com/elboulangero)) - [`a60882b`](https://togithub.com/gomodule/redigo/commit/a60882bf9e77d7f428bdfa7e27516979d833f663): chore: update testify ([#​653](https://togithub.com/gomodule/redigo/issues/653)) ([@​stevenh](https://togithub.com/stevenh)) - [`9129745`](https://togithub.com/gomodule/redigo/commit/91297458446615564ead7370d273480ccd2120f3): chore: update github actions and fix tests ([#​657](https://togithub.com/gomodule/redigo/issues/657)) ([@​stevenh](https://togithub.com/stevenh)) ##### Continuous Integration - [`1bfd3c1`](https://togithub.com/gomodule/redigo/commit/1bfd3c16b111e999b1ba506ad0613c8322a97848): ci: add goreleaser, update action and go versions ([#​662](https://togithub.com/gomodule/redigo/issues/662)) ([@​stevenh](https://togithub.com/stevenh)) #### New Contributors - [@​elboulangero](https://togithub.com/elboulangero) made their first contribution in [https://github.com/gomodule/redigo/pull/654](https://togithub.com/gomodule/redigo/pull/654) - [@​vasayxtx](https://togithub.com/vasayxtx) made their first contribution in [https://github.com/gomodule/redigo/pull/660](https://togithub.com/gomodule/redigo/pull/660) [Full Changelog](https://togithub.com/gomodule/redigo/compare/v1.8.9...v1.9.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ffddorf/terraform-backend). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TestOnBorrowContext to the Pool struct for checking the health of the idle connection with a given context.