fix: respect ctx in cmds run within DialContext#620
Merged
stevenh merged 1 commit intogomodule:masterfrom Jul 1, 2022
Merged
Conversation
stevenh
approved these changes
Jul 1, 2022
Contributor
Author
|
Thanks @stevenh! Is it possible to please merge & tag this fix? |
Collaborator
|
To make sure you didn't miss it tag was done last week @mitchsw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DialContext()function does not use the newDoContext()methods (added in v1.8.6) when configuring auth/clientName/db during connection creation. If the Redis server is unresponsive, this can causeDialContext()to run for a very long time (instead of cancelling when the deadline is exceeded).DoContextshould be used for these cmds.Repro steps:
CLIENT PAUSE 36000000 ALLDialContext()with a 1sec timeout