implemented durable search providers for golem:search #69
Merged
vigoo merged 53 commits intogolemcloud:mainfrom Jul 19, 2025
Merged
implemented durable search providers for golem:search #69vigoo merged 53 commits intogolemcloud:mainfrom
vigoo merged 53 commits intogolemcloud:mainfrom
Conversation
Contributor
Author
typesenseScreencast.from.2025-07-10.18-29-04.webm |
Contributor
Author
opensearchScreencast.from.2025-07-11.17-05-04.webm |
Contributor
Author
meilisearchScreencast.from.2025-07-08.19-17-59.webm |
Contributor
Author
algoliaScreencast.from.2025-07-08.15-38-33.webm |
Contributor
Author
elasticsearchScreencast.from.2025-07-08.23-35-37.webm |
vigoo
approved these changes
Jul 19, 2025
Collaborator
vigoo
left a comment
There was a problem hiding this comment.
Looks very good! Added a minor comment about making some test jsons more readable.
Otherwise please merge with latest main, and run cargo make fix using the latest stable rust to fix the clippy issuse, then ready for merging.
Contributor
Author
|
@vigoo ready for merge ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #32
/closes #32