Skip to content

feat: aws bedrock llm implementation#50

Closed
rutikthakre wants to merge 8 commits intogolemcloud:mainfrom
rutikthakre:bedrock
Closed

feat: aws bedrock llm implementation#50
rutikthakre wants to merge 8 commits intogolemcloud:mainfrom
rutikthakre:bedrock

Conversation

@rutikthakre
Copy link
Copy Markdown
Contributor

@rutikthakre rutikthakre commented Jun 26, 2025 •
edited
Loading

Added AWS bedrock via its converse api link

  • Used AWS bedrock api, which is the same as other LLM providers.
  • Does not use any extra crates like AWS Bedrock, tokio, which leads to smaller builds except aws-smithy-eventstream which need to parse stream events
  • Supports polling

closes #2
/claim #2

@algora-pbc algora-pbc bot mentioned this pull request Jun 26, 2025
Closed
@rutikthakre rutikthakre marked this pull request as draft June 26, 2025 10:17
@rutikthakre rutikthakre marked this pull request as ready for review June 30, 2025 09:24
@mschuwalow
Copy link
Copy Markdown
Contributor

mschuwalow commented Jul 3, 2025

Please add a short video showcasing the passing testcases

@rutikthakre
Copy link
Copy Markdown
Contributor Author

rutikthakre commented Jul 3, 2025

@mschuwalow Hi here the link to the video https://drive.google.com/file/d/1LHxIgjyz8l7pM0uAUq3J_8D3caLoUJG2/view?usp=sharing showcasing the testing and I was facing some problem related golem. Which I talked about on hackathon channel https://discord.com/channels/1134448700572319785/1157293164512690267/1389291819925246093

@rutikthakre
Copy link
Copy Markdown
Contributor Author

rutikthakre commented Jul 3, 2025

All test passes individually but when run in sync one after one then test 3rd or some times 4th fails. I guess it is may be because my system configurations

@rutikthakre
Copy link
Copy Markdown
Contributor Author

rutikthakre commented Jul 5, 2025

@mschuwalow @vigoo Please check here

@mschuwalow Hi here the link to the video https://drive.google.com/file/d/1LHxIgjyz8l7pM0uAUq3J_8D3caLoUJG2/view?usp=sharing showcasing the testing and I was facing some problem related golem. Which I talked about on hackathon channel https://discord.com/channels/1134448700572319785/1157293164512690267/1389291819925246093

@rutikthakre rutikthakre mentioned this pull request Jul 5, 2025
Closed
@rutikthakre
Copy link
Copy Markdown
Contributor Author

rutikthakre commented Jul 7, 2025 •
edited
Loading

@mschuwalow Please check this demo video

bedrock.2.mp4

@rutikthakre rutikthakre marked this pull request as draft July 10, 2025 12:41
@rutikthakre rutikthakre marked this pull request as ready for review July 10, 2025 12:41
mschuwalow
mschuwalow approved these changes Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mschuwalow mschuwalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very reasonable implementation on top of the raw HTTP client.
I'll discuss with my colleagues whether we prefer this approach or the one in #27 from a maintenance perspective.

@vigoo
Copy link
Copy Markdown
Collaborator

vigoo commented Jul 19, 2025

Closing as we chose to merge the other attempt (#27). Thank you for your work!

@vigoo vigoo closed this Jul 19, 2025
@rutikthakre rutikthakre deleted the bedrock branch July 23, 2025 14:33
@rutikthakre rutikthakre mentioned this pull request Aug 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mschuwalow mschuwalow mschuwalow approved these changes

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add AWS Bedrock Provider

3 participants

@rutikthakre @mschuwalow @vigoo