Merged
Conversation
Add wit changes Add Durability for Inline Implement for Openai, Openrouter,anthropic,grok Add Test7
Contributor
Author
|
Build and Test Pass but I can add error: the `Err`-variant returned from this function is very large
--> llm/src/event_source/mod.rs:37:39
|
37 | pub fn new(response: Response) -> Result<Self, Error> {
| ^^^^^^^^^^^^^^^^^^^
|
::: llm/src/event_source/error.rs:42:5
|
42 | InvalidContentType(HeaderValue, Response),
| ----------------------------------------- the largest variant contains at least 288 bytes
...
45 | InvalidStatusCode(StatusCode, Response),
| --------------------------------------- the variant `InvalidStatusCode` contains at least 250 bytes
|
= help: try reducing the size of `event_source::error::Error`, for example by boxing large elements or replacing it with `Box<event_source::error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
= note: `-D clippy::result-large-err` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::result_large_err)]`
error: the `Err`-variant returned from this function is very large
--> llm/src/event_source/mod.rs:97:42
|
97 | fn check_response(response: Response) -> Result<Response, Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
::: llm/src/event_source/error.rs:42:5
|
42 | InvalidContentType(HeaderValue, Response),
| ----------------------------------------- the largest variant contains at least 288 bytes
...
45 | InvalidStatusCode(StatusCode, Response),
| --------------------------------------- the variant `InvalidStatusCode` contains at least 250 bytes
|
= help: try reducing the size of `event_source::error::Error`, for example by boxing large elements or replacing it with `Box<event_source::error::Error>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
error: could not compile `golem-llm` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `golem-llm` (lib test) due to 2 previous errors
Error while executing command, exit code: 101 |
Collaborator
|
The new lint errors are coming because of the new Rust version (1.87). CI is always using the latest stable. It's ok to add |
Contributor
Author
|
Done, Fixed clippy by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/closes #13
/claim #13
Link to Video -
Video Includes running test5 and test7 for anthropic, grok, openai, openrouter
Test is run by
golem-cli app deploy --build-profile <model>-deugspecific envgolem-cli worker invoke <worker> test5andgolem-cli worker invoke <worker> test7Changes to the WIT
In a earlier commit, I used
content-part {text, image-url, image-inline}.Choose this over earlier idea and made both
image-urlandimage-sourceas part of the sameimage(image-reference).OpenAI, Grok and Openrouter support inline image under image-url with small syntax change (Straight forward implementation)
Anthropic has a direct way to pass Base64 Image (Uses the inbuilt Base64 to pass the Image)
Test 7
There is cat.png under
data/cat.pngin test. We use golem Initial file system (using yaml) and the have the workers import the cat image as byte array, and get a response with the description of the imageTest 5
Test 5 previously did not have an output (unsure why ?), we now output the contents of LLM call as string, This is needed as CI ollama test can assert for output for all tests.
Added a few test in
durablity.rsfor base64 images