Skip to content

add pgvector types to golem rdbms postgres #2504

Merged
vigoo merged 19 commits intogolemcloud:mainfrom
justcoon:rdbms_pgvector
Dec 27, 2025
Merged

add pgvector types to golem rdbms postgres #2504
vigoo merged 19 commits intogolemcloud:mainfrom
justcoon:rdbms_pgvector

Conversation

@justcoon
Copy link
Copy Markdown
Contributor

@justcoon justcoon commented Dec 15, 2025 •
edited
Loading

fixes: #2497
/claim #2497

add pgvector types to https://github.com/golemcloud/golem/blob/main/wit/deps/golem-rdbms/postgres.wit

NOTE: as wit do not have support for f16, f32 is used in db-value::halfvec wit type

TODO:

  • fix CLI tests failures

current setup in relation to CLI and ts test components using released version of golem-ts-sdk

for example test_naming_extremes test with component

test-naming-extremes % cat package.json
{
  "name": "app",
  "workspaces": [
    "common-js/*/*",
    "components-js/*/*",
    "common-ts/*/*",
    "components-ts/*/*"
  ],
  "dependencies": {
    "@golemcloud/golem-ts-sdk": "0.0.74"
  },
  "devDependencies": {
    "@rollup/plugin-alias": "^5.1.1",
    "@rollup/plugin-node-resolve": "^16.0.1",
    "@rollup/plugin-typescript": "^12.1.4",
    "@rollup/plugin-commonjs": "^28.0.6",
    "@rollup/plugin-json": "^6.1.0",
    "@types/node": "^24.3.1",
    "rollup": "^4.50.1",
    "tslib": "^2.8.1",
    "typescript": "^5.9.2",
    "@golemcloud/golem-ts-typegen": "0.0.74"
  }
}

which missing latest changes

locally with

% export GOLEM_TS_PACKAGES_PATH=<PATH_TO_GOLEM_PROJECT>/sdks/ts/packages

tests are passing without failure

related change:
cli-integration-tests-group3 changed to use golem-ts-sdk from branch (sdks/ts/packages)

@algora-pbc algora-pbc bot mentioned this pull request Dec 15, 2025
Closed
@vigoo
Copy link
Copy Markdown
Contributor

vigoo commented Dec 16, 2025

This can go in after the 1.4 release (end of this week), we don't want to change the WITs before it.

@justcoon justcoon force-pushed the rdbms_pgvector branch 9 times, most recently from 32c0cb3 to 55a66cd Compare December 22, 2025 19:32
@justcoon justcoon mentioned this pull request Dec 23, 2025
Open
vigoo
vigoo approved these changes Dec 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vigoo vigoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving as the main change looks good, there maybe some more merging/wit/test updating needed to make it green.
For example I think the WIT worlds in the SDKs need to be updated (both rust and ts, in the sdks dir) to import the updated rdbms package version.

@justcoon justcoon force-pushed the rdbms_pgvector branch 3 times, most recently from ea17f29 to d09346c Compare December 25, 2025 21:08
@vigoo vigoo merged commit 5b2f8c7 into golemcloud:main Dec 27, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vigoo vigoo vigoo approved these changes

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add pgvector types to golem rdbms postgres

2 participants

@justcoon @vigoo