Merged
Conversation
Owner
|
This is nigh impossible to review, being both very long and very boring. (Boring = good, in this sense.) Is there particular feedback you seek? |
Collaborator
Author
|
Excellent! "Boring" the best review I could have hoped for :) |
There were several places in `singletons` that would compute entirely different things depending on the order in which GHC's unique numbers happened to be computed. Like the corresponding `th-desugar` patch (in goldfirere/th-desugar#115), this fixes these issues by swapping out nondeterministic uses of `Map` and `Set` with `th-desugar`'s new `OMap` and `OSet` data structures, which remember the order in which elements were inserted. This patch looks large, but half of the modifications are routine changes brought about by switching data structures, and the other half are test suite wibbles brought about by `singletons` settling on a deterministic order for the expected output. The upshot is that we can finally run the `singletons` test suite with `-dunique-increment=-1` and have it still pass! Hooray! Fixes #367.
d073ea8 to
0a175d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were several places in
singletonsthat would compute entirely different things depending on the order in which GHC's unique numbers happened to be computed. Like the correspondingth-desugarpatch (in goldfirere/th-desugar#115), this fixes these issues by swapping out nondeterministic uses ofMapandSetwithth-desugar's newOMapandOSetdata structures, which remember the order in which elements were inserted.This patch looks large, but half of the modifications are routine changes brought about by switching data structures, and the other half are test suite wibbles brought about by
singletonssettling on a deterministic order for the expected output. The upshot is that we can finally run thesingletonstest suite with-dunique-increment=-1and have it still pass! Hooray!Fixes #367.