cpu: support darwin/arm64 CPU feature detection by howjmay · Pull Request #114 · golang/sys

howjmay · 2021-07-03T17:47:31Z

Support ARM64 features detection. The CPU features which are supported by
Apple Silicon M1 are assumed as the minimal set of features for Go programs
running on darwin/arm64.

The ARM64 supporting features are referred to
https://en.wikichip.org/wiki/arm/armv8#ARMv8_Extensions_and_Processor_Features

close golang/go#42747

gopherbot · 2021-07-03T17:51:33Z

This PR (HEAD: 107027e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-03T17:59:57Z

This PR (HEAD: 1ba4687) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-05T17:55:46Z

Message from Martin Möhrmann:

Patch Set 4:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-07T01:30:21Z

This PR (HEAD: c3be48e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-07T01:32:45Z

This PR (HEAD: cfc9f86) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-07T01:35:12Z

This PR (HEAD: e57cd24) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-07T01:37:32Z

This PR (HEAD: dbeb491) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-07T03:01:00Z

This PR (HEAD: 76cf32c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-07T03:03:28Z

Message from Hau Yang:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-07T03:08:15Z

Message from Hau Yang:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-07T05:29:22Z

Message from Martin Möhrmann:

Patch Set 10:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-07T16:04:40Z

This PR (HEAD: a305a6c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-07T16:25:15Z

This PR (HEAD: 7244160) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-07T16:32:53Z

Message from Hau Yang:

Patch Set 12:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-10T09:16:59Z

This PR (HEAD: 54c2df7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-10T09:48:56Z

This PR (HEAD: 7942793) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-11-08T10:59:45Z

Message from Hau Yang:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:46Z

Message from Martin Möhrmann:

Patch Set 10:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:47Z

Message from Hau Yang:

Patch Set 12:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

Support ARM64 features detection. The CPU features which are supported by Apple Silicon M1 are assumed as the minimal set of features for Go programs running on darwin/arm64. The ARM64 supporting features are referred to https://en.wikichip.org/wiki/arm/armv8#ARMv8_Extensions_and_Processor_Features

gopherbot · 2022-09-04T12:35:09Z

Message from Eric Lagergren:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-04T12:35:10Z

Message from Daniel Martí:

Patch Set 14:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-04T12:35:10Z

Message from Eric Lagergren:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-04T12:35:11Z

Message from Daniel Martí:

Patch Set 14:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-04T12:35:12Z

Message from Koichi Shiraishi:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-09-04T12:35:16Z

This PR (HEAD: 44d7b39) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/332729 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-09-04T12:39:10Z

Message from Hau Yang:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332729.
After addressing review feedback, remember to publish your drafts!

google-cla bot added the cla: yes label Jul 3, 2021

howjmay force-pushed the detect-apple-m1-features branch from 107027e to 1ba4687 Compare July 3, 2021 17:57

howjmay force-pushed the detect-apple-m1-features branch from 1ba4687 to c3be48e Compare July 7, 2021 01:28

howjmay force-pushed the detect-apple-m1-features branch from c3be48e to cfc9f86 Compare July 7, 2021 01:32

howjmay force-pushed the detect-apple-m1-features branch 2 times, most recently from 021ce95 to e57cd24 Compare July 7, 2021 01:34

howjmay force-pushed the detect-apple-m1-features branch from e57cd24 to dbeb491 Compare July 7, 2021 01:35

howjmay force-pushed the detect-apple-m1-features branch from dbeb491 to 76cf32c Compare July 7, 2021 02:58

howjmay changed the title ~~cpu: support darwin/arm64 CPU feature detection~~ cpu: extend arm64 CPU feature detection Jul 7, 2021

howjmay changed the title ~~cpu: extend arm64 CPU feature detection~~ cpu: extend arm64 support on CPU feature detection Jul 7, 2021

howjmay force-pushed the detect-apple-m1-features branch from 76cf32c to a305a6c Compare July 7, 2021 16:03

howjmay changed the title ~~cpu: extend arm64 support on CPU feature detection~~ cpu: support darwin/arm64 CPU feature detection Jul 7, 2021

howjmay force-pushed the detect-apple-m1-features branch from a305a6c to 7244160 Compare July 7, 2021 16:22

howjmay force-pushed the detect-apple-m1-features branch from 7244160 to 54c2df7 Compare July 10, 2021 09:15

howjmay force-pushed the detect-apple-m1-features branch from 54c2df7 to 7942793 Compare July 10, 2021 09:46

ianlancetaylor mentioned this pull request Nov 8, 2021

x/build/cmd/gerritbot: posts duplicate messages whenever Gerrit message IDs change golang/go#49467

Open

howjmay force-pushed the detect-apple-m1-features branch from 7942793 to 44d7b39 Compare September 4, 2022 12:32

Conversation

howjmay commented Jul 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jul 3, 2021

Uh oh!

gopherbot commented Jul 3, 2021

Uh oh!

gopherbot commented Jul 5, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 7, 2021

Uh oh!

gopherbot commented Jul 10, 2021

Uh oh!

gopherbot commented Jul 10, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Sep 4, 2022

Uh oh!

gopherbot commented Sep 4, 2022

Uh oh!

gopherbot commented Sep 4, 2022

Uh oh!

gopherbot commented Sep 4, 2022

Uh oh!

gopherbot commented Sep 4, 2022

Uh oh!

gopherbot commented Sep 4, 2022

Uh oh!

gopherbot commented Sep 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

howjmay commented Jul 3, 2021 •

edited

Loading